You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "liuyongvs (via GitHub)" <gi...@apache.org> on 2023/04/25 08:33:50 UTC
[GitHub] [flink] liuyongvs opened a new pull request, #22483: [FLINK-31118][table] Add ARRAY_UNION function.
liuyongvs opened a new pull request, #22483:
URL: https://github.com/apache/flink/pull/22483
- What is the purpose of the change
This is an implementation of ARRAY_UNION
- Brief change log
ARRAY_UNION for Table API and SQL
```
Returns an array of the elements in the union of array1 and array2, without duplicates.
Syntax:
array_union(array1, array2)
Arguments:
array: An ARRAY to be handled.
Returns:
An ARRAY. If any of the array is null, the function will return null.
Examples:
> SELECT array_union(array(1, 2, 3), array(1, 3, 5));
[1,2,3,5]
```
See also
spark https://spark.apache.org/docs/latest/api/sql/index.html#array_union
presto https://prestodb.io/docs/current/functions/array.html
- Verifying this change
This change added tests in CollectionFunctionsITCase.
- Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes )
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
The S3 file system connector: ( no)
- Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #22483: [FLINK-31118][table] Add ARRAY_UNION function.
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #22483:
URL: https://github.com/apache/flink/pull/22483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22483: [FLINK-31118][table] Add ARRAY_UNION function.
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22483:
URL: https://github.com/apache/flink/pull/22483#issuecomment-1521401842
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "71f999f19582af065e69e07e4dcd72598a62fffa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71f999f19582af065e69e07e4dcd72598a62fffa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71f999f19582af065e69e07e4dcd72598a62fffa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a diff in pull request #22483: [FLINK-31118][table] Add ARRAY_UNION function.
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #22483:
URL: https://github.com/apache/flink/pull/22483#discussion_r1194882563
##########
docs/data/sql_functions.yml:
##########
@@ -643,6 +643,9 @@ collection:
- sql: ARRAY_REVERSE(haystack)
table: haystack.arrayReverse()
description: Returns an array in reverse order. If the array itself is null, the function will return null.
+ - sql: ARRAY_UNION(array1, array2)
+ table: haystack.arrayUnion(array)
Review Comment:
nit: `haystack` does not make sense in this context imo. It's a nice joke but imo works only for `ARRAY_CONTAINS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuyongvs commented on pull request #22483: [FLINK-31118][table] Add ARRAY_UNION function.
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #22483:
URL: https://github.com/apache/flink/pull/22483#issuecomment-1521402397
hi @snuyanzin i submit a new pr and close this https://github.com/apache/flink/pull/21958.
The new implementation considers the issue of type conversion and refers to the spark implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org