[jira] [Comment Edited] (RATIS-730) Fix checkstyle violations in ratis-examples

["Dinesh Chitlangia (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977771#comment-16977771 ] 

Dinesh Chitlangia edited comment on RATIS-730 at 11/19/19 7:30 PM:
-------------------------------------------------------------------

[~szetszwo] I am thinking we should move the code from method parsePeers to getParsedPeers.

{code:java}
public static RaftPeer[] parsePeers(String peers) {
    return Stream.of(peers.split(",")).map(address -> {
      String[] addressParts = address.split(":");
      return new RaftPeer(RaftPeerId.valueOf(addressParts[0]),
          addressParts[1] + ":" + addressParts[2]);
    }).toArray(RaftPeer[]::new);
  }

  public RaftPeer[] getParsedPeers() {
    return parsePeers(peers);
  }
{code}

Change to :
{code}
public RaftPeer[] getParsedPeers() {
    return Stream.of(peers.split(",")).map(address -> {
      String[] addressParts = address.split(":");
      return new RaftPeer(RaftPeerId.valueOf(addressParts[0]),
              addressParts[1] + ":" + addressParts[2]);
    }).toArray(RaftPeer[]::new);
  }
{code} 
and remove getParsePeers().


was (Author: dineshchitlangia):
[~szetszwo] I am thinking we should move the code from method parsePeers to getParsedPeers.

{code:java}
public static RaftPeer[] parsePeers(String peers) {
    return Stream.of(peers.split(",")).map(address -> {
      String[] addressParts = address.split(":");
      return new RaftPeer(RaftPeerId.valueOf(addressParts[0]),
          addressParts[1] + ":" + addressParts[2]);
    }).toArray(RaftPeer[]::new);
  }

  public RaftPeer[] getParsedPeers() {
    return parsePeers(peers);
  }
{code}

Change to :
{code}
public RaftPeer[] getParsedPeers() {
    return Stream.of(peers.split(",")).map(address -> {
      String[] addressParts = address.split(":");
      return new RaftPeer(RaftPeerId.valueOf(addressParts[0]),
              addressParts[1] + ":" + addressParts[2]);
    }).toArray(RaftPeer[]::new);
  }
{code} 
and remove getPeers() as it is just calling the other method and not performing any other operations.


> Fix checkstyle violations in ratis-examples
> -------------------------------------------
>
>                 Key: RATIS-730
>                 URL: https://issues.apache.org/jira/browse/RATIS-730
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: RATIS-730.001.patch, RATIS-730.002.patch, RATIS-730.003.patch, RATIS-730.004.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Jira to fix checkstyle violations in ratis-examples module



--
This message was sent by Atlassian Jira
(v8.3.4#803005)