You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dmitry Malinin (JIRA)" <ji...@apache.org> on 2017/04/07 08:35:41 UTC

[jira] [Updated] (LUCENE-7769) UnifiedHighlighter doesn't highlight PrefixQuery wrapped in BootsQuery

     [ https://issues.apache.org/jira/browse/LUCENE-7769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Malinin updated LUCENE-7769:
-----------------------------------
    Description: 
{noformat}
UnifiedHighlighter doesn't highlight MTQ wrapped in BootsQuery.
For example, suppose we have a doc with a field 'f' contains data 'lucene'. 
UnifiedHighlighter highlights query (f:lucene*), but query (f:lucene*)^1 doesn't. Test code:
String field = "f";
String content = "lucene";
Term term = new Term(field, content);
UnifiedHighlighter highlighter = new UnifiedHighlighter(null, new StandardAnalyzer());
Query[] queries = {new PrefixQuery(term), new BoostQuery(new PrefixQuery(term), 1.0f)};
Object fragObj;		
for (Query query : queries)
{
	fragObj = highlighter.highlightWithoutSearcher(field, query, content, 1);
	System.out.printf("content=[%s]  Query=%s  frag=[%s]\n", content, query, fragObj);
}
My opinion is because MultiTermHighlighting.extractAutomata() returns an empty automaton for BoostQuery. I think, should add some thing like:
 if (query instanceof BoostQuery) {
      list.addAll(Arrays.asList(extractAutomata(((BoostQuery) query).getQuery(), fieldMatcher, lookInSpan,
          preRewriteFunc))) ; } 
to MultiTermHighlighting.extractAutomata()
Thanks.
{noformat}

  was:
{noformat}
UnifiedHighlighter doesn't highlight MTQ wrapped in BootsQuery.
For example, suppose we have a doc with a field 'f' contains data 'lucene'. UnifiedHighlighter highlights query (f:lucene*), but query (f:lucene*)^1 doesn't. Test code:
String field = "f";
String content = "lucene";
Term term = new Term(field, content);
UnifiedHighlighter highlighter = new UnifiedHighlighter(null, new StandardAnalyzer());
Query[] queries = {new PrefixQuery(term), new BoostQuery(new PrefixQuery(term), 1.0f)};
Object fragObj;		
for (Query query : queries)
{
	fragObj = highlighter.highlightWithoutSearcher(field, query, content, 1);
	System.out.printf("content=[%s]  Query=%s  frag=[%s]\n", content, query, fragObj);
}
My opinion is because MultiTermHighlighting.extractAutomata() returns an empty automaton for BoostQuery. I think, should add some thing like:
 if (query instanceof BoostQuery) {
      list.addAll(Arrays.asList(extractAutomata(((BoostQuery) query).getQuery(), fieldMatcher, lookInSpan,
          preRewriteFunc))) ; } 
to MultiTermHighlighting.extractAutomata()
Thanks.
{noformat}


> UnifiedHighlighter doesn't highlight PrefixQuery wrapped in BootsQuery
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-7769
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7769
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 6.5, 6.4.2
>            Reporter: Dmitry Malinin
>
> {noformat}
> UnifiedHighlighter doesn't highlight MTQ wrapped in BootsQuery.
> For example, suppose we have a doc with a field 'f' contains data 'lucene'. 
> UnifiedHighlighter highlights query (f:lucene*), but query (f:lucene*)^1 doesn't. Test code:
> String field = "f";
> String content = "lucene";
> Term term = new Term(field, content);
> UnifiedHighlighter highlighter = new UnifiedHighlighter(null, new StandardAnalyzer());
> Query[] queries = {new PrefixQuery(term), new BoostQuery(new PrefixQuery(term), 1.0f)};
> Object fragObj;		
> for (Query query : queries)
> {
> 	fragObj = highlighter.highlightWithoutSearcher(field, query, content, 1);
> 	System.out.printf("content=[%s]  Query=%s  frag=[%s]\n", content, query, fragObj);
> }
> My opinion is because MultiTermHighlighting.extractAutomata() returns an empty automaton for BoostQuery. I think, should add some thing like:
>  if (query instanceof BoostQuery) {
>       list.addAll(Arrays.asList(extractAutomata(((BoostQuery) query).getQuery(), fieldMatcher, lookInSpan,
>           preRewriteFunc))) ; } 
> to MultiTermHighlighting.extractAutomata()
> Thanks.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org