You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by bjmoor <gi...@git.apache.org> on 2016/11/13 22:17:51 UTC
[GitHub] tinkerpop pull request #490: GraphSON decode of Vertex and Edge properties
GitHub user bjmoor opened a pull request:
https://github.com/apache/tinkerpop/pull/490
GraphSON decode of Vertex and Edge properties
If the server sends properties back with the Vertices and Edges, gremlin_python should deserialize the properties and make them available.
This patch will add the properties to the returned Vertex, Edge, VertexProperty or Property, if and only if, the "properties" are returned.
By default, gremlin-server will not return Properties or Labels of elements. However, when using a DetachedFactory HaltedTraverserStrategy, the server will return these properties.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjmoor/tinkerpop python_properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #490
----
commit 1fc4d981b87a68711ec25e159506c00232caa90b
Author: Branden Moore <bj...@sandia.gov>
Date: 2016-11-13T15:53:41Z
[gremlin_python] If properties are sent with an element, deserialize them
commit a9fc23293b38fc36c404882124db1760383786cd
Author: Branden Moore <bj...@sandia.gov>
Date: 2016-11-13T21:58:50Z
[gremlin-python] Add tests for property deserialization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/490
@okram pinged me on the side and filled me in with some background info i wasn't aware of - the short of it is that a lot of work has been done in this area on the aforementioned tickets and if you'd like to contribute you should probably coordinate with those working on TINKERPOP-1565 at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/490
Dah. I didn't see this ticket. I'm doing this (along with other things) in TINKERPOP-1520. Hmm... perhaps you can provide a PR to that branch ... In particular your test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/490
yes - i think you can close this one since the work is already underway elsewhere. thanks for submitting this though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #490: TINKERPOP-1474 GraphSON decode of Vertex and Ed...
Posted by bjmoor <gi...@git.apache.org>.
Github user bjmoor closed the pull request at:
https://github.com/apache/tinkerpop/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: GraphSON decode of Vertex and Edge properties
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/490
Thanks for this. Would you mind including tests for `Edge` and `VertexProperty`? Also, could you please edit your PR to have TINKERPOP-1474 as the prefix to the rest of your text in the name as in:
"TINKERPOP-1474 GraphSON decode of Vertex and Edge properties"
This change applies to that ticket I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/490
TINKERPOP-1420 has merged to master. @bjmoor do you want to rebase your PR? note this area of development is still somewhat in flux on master given:
https://issues.apache.org/jira/browse/TINKERPOP-1565
Perhaps the best option would be to target this work at the tp32 branch where GraphSON 2.0 is stable. wdyt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #490: TINKERPOP-1474 GraphSON decode of Vertex and Edge prop...
Posted by bjmoor <gi...@git.apache.org>.
Github user bjmoor commented on the issue:
https://github.com/apache/tinkerpop/pull/490
It looks like the work being done in TINKERPOP-1565 will be addressing the issue which this PR was attempting to address, and probably in a more effective manner. Should I just close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---