You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 19:15:45 UTC

[GitHub] [incubator-superset] robdiciuccio opened a new pull request #11398: docs: Add semantic prefix info for PR titles

robdiciuccio opened a new pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398


   ### SUMMARY
   Documents the PR title semantics enforced via the [linting script](https://github.com/apache/incubator-superset/blob/master/.github/workflows/pr-lint.yml) in `CONTRIBUTING.md`.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai merged pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714843293


   retriggering CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `1.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.49%   -1.17%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25093   -14873     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15181    -9462     
   + Misses      15142     9912    -5230     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.49% <ø> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.30% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.15%)` | :arrow_down: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   + Coverage   61.65%   61.82%   +0.16%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40090     +124     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    24785     +142     
   + Misses      15142    15124      -18     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `61.14% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `34.84% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | `66.66% <0.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **increase** coverage by `4.42%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   + Coverage   61.65%   66.08%   +4.42%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40093     +127     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    26496    +1853     
   + Misses      15142    13496    -1646     
   + Partials      181      101      -80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.35% <ø> (?)` | |
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `61.14% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/TableLoader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVMb2FkZXIuanN4) | | |
   | ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   + Coverage   61.65%   61.82%   +0.16%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40090     +124     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    24786     +143     
   + Misses      15142    15123      -19     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `61.14% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `34.84% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | `66.66% <0.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (ø)` | |
   | [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714793907


   To add to what @villebro said, eventually we can have an allow-list of subtopics and auto-label PRs based on the topic/subtopic. This is a great first step!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `1.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.48%   -1.18%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25104   -14862     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15184    -9459     
   + Misses      15142     9920    -5222     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.48% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.30% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.62% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | | |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `1.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.45%   -1.21%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25093   -14873     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15169    -9474     
   + Misses      15142     9924    -5218     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.45% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.30% <0.00%> (-0.84%)` | :arrow_down: |
   | ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **increase** coverage by `4.42%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   + Coverage   61.65%   66.08%   +4.42%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40093     +127     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    26496    +1853     
   + Misses      15142    13496    -1646     
   + Partials      181      101      -80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.35% <ø> (?)` | |
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `61.14% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/TableLoader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVMb2FkZXIuanN4) | | |
   | ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `1.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.38%   -1.28%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25093   -14873     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15152    -9491     
   + Misses      15142     9941    -5201     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.38% <ø> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.46% <0.00%> (-1.68%)` | :arrow_down: |
   | ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `0.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.74%   -0.92%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25104   -14862     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15249    -9394     
   + Misses      15142     9855    -5287     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.74% <ø> (-0.32%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | | |
   | [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | |
   | [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
   | [...ntend/src/components/dataViewCommon/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vUGFnaW5hdGlvbi50c3g=) | | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | | |
   | [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9sb2NhbFN0b3JhZ2VVc2FnZS5qcw==) | | |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   61.57%   -0.09%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40090     +124     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    24684      +41     
   - Misses      15142    15225      +83     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `60.74% <ø> (-0.32%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `34.84% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **increase** coverage by `4.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   + Coverage   61.65%   65.93%   +4.27%     
   ==========================================
     Files         839      840       +1     
     Lines       39966    40093     +127     
     Branches     3662     3685      +23     
   ==========================================
   + Hits        24643    26437    +1794     
   + Misses      15142    13551    -1591     
   + Partials      181      105      -76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.68% <ø> (?)` | |
   | #javascript | `62.95% <ø> (+0.28%)` | :arrow_up: |
   | #python | `61.14% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `83.33% <0.00%> (-10.61%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4) | `95.83% <0.00%> (-0.17%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/TableLoader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVMb2FkZXIuanN4) | | |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai closed pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
nytai closed pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11398: docs: Add semantic prefix info for PR titles

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11398:
URL: https://github.com/apache/incubator-superset/pull/11398#issuecomment-714715665


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=h1) Report
   > Merging [#11398](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00e394451f39adddf5678961eacbacf7f0ca70e9?el=desc) will **decrease** coverage by `0.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11398/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11398      +/-   ##
   ==========================================
   - Coverage   61.65%   60.74%   -0.92%     
   ==========================================
     Files         839      396     -443     
     Lines       39966    25104   -14862     
     Branches     3662        0    -3662     
   ==========================================
   - Hits        24643    15249    -9394     
   + Misses      15142     9855    -5287     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `60.74% <ø> (-0.32%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | | |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | | |
   | [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | | |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | | |
   | [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | | |
   | [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | | |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11398/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=footer). Last update [00e3944...40cd42d](https://codecov.io/gh/apache/incubator-superset/pull/11398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org