You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2015/11/20 14:50:37 UTC
[GitHub] incubator-brooklyn pull request: EntitySpec duplication should inc...
GitHub user duncangrant opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1051
EntitySpec duplication should include children
If the memberspec of a dynamiccluster had a child entityspec then it would not be possible to set or expand the cluster to more than 1 node. This is because when addentity is called the parent entity is set on the childspec. The dynamic cluster uses EntitySpec.create to duplicate the memberspec however this doesn't duplicate any children so the original and duplicate entityspecs share children.
When using EntitySpec.create to duplicate an entityspec this change duplicates children rather than attaching original child specs.
https://issues.apache.org/jira/browse/BROOKLYN-192
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/incubator-brooklyn fix/entityspec-duplication
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1051
----
commit 4c21e4ffff61033bf5a7875224c6ac5726fa358b
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2015-11-19T16:38:12Z
EntitySpec duplication includes children
When using EntitySpec.create to duplicate an entityspec this change
duplicates children rather than attaching original child specs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: EntitySpec duplication should inc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1051
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: EntitySpec duplication should inc...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1051#issuecomment-159025220
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---