You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/06/09 07:09:48 UTC

[GitHub] [doris] xinyiZzz commented on a diff in pull request #20635: [fix](case expr) fix coredump of case for null value 2

xinyiZzz commented on code in PR #20635:
URL: https://github.com/apache/doris/pull/20635#discussion_r1223928589


##########
be/src/vec/functions/function_case.h:
##########
@@ -332,13 +332,15 @@ class FunctionCase : public IFunction {
         bool then_null = false;
         for (int i = 1 + has_case; i < arguments.size() - has_else; i += 2) {
             auto then_column_ptr = block.get_by_position(arguments[i]).column;
-            if (then_column_ptr->is_nullable() || then_column_ptr->only_null()) {
+            if (then_column_ptr->is_nullable() ||

Review Comment:
   It seems to be ok, for `ColumnConst`, it seems that `get_data_type() == TypeIndex::Nullable` is the real `is_nullable`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org