You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/12/18 22:29:55 UTC
[PR] Add A "upgrading to 0.13.0" guide in docs [arrow-rs-object-store]
alamb opened a new pull request, #584:
URL: https://github.com/apache/arrow-rs-object-store/pull/584
# Which issue does this PR close?
- Part of https://github.com/apache/arrow-rs-object-store/issues/367
# Rationale for this change
While testing the upgrade to object_store 0.13.0 I came across some gotchas that I wanted to document to help others upgrade (also to help prompt LLMs to upgrade)
# What changes are included in this PR?
1. Add an "upgrading to 0.13.0" section
2.
# Are there any user-facing changes?
Docs only, no functional changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add A "upgrading to 0.13.0" guide in docs [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #584:
URL: https://github.com/apache/arrow-rs-object-store/pull/584#issuecomment-3675186113
Looks like I accidentally committed an earlier version of the guide in https://github.com/apache/arrow-rs-object-store/pull/583
I'll just merge this PR in with tweaks and cut the release candidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add A "upgrading to 0.13.0" guide in docs [arrow-rs-object-store]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #584:
URL: https://github.com/apache/arrow-rs-object-store/pull/584#discussion_r2632911102
##########
src/lib.rs:
##########
@@ -694,6 +694,48 @@ pub type MultipartId = String;
///
/// To automatically detect this issue, use
/// [`#[deny(clippy::missing_trait_methods)]`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_trait_methods).
+///
+/// # Upgrade Guide for 0.13.0
+///
+/// Upgrading to object_store 0.13.0 from an earlier version typically involves:
+///
+/// 1. Add a `use` for [`ObjectStoreExt`] to solve the error
+///
+/// ```text
+/// error[E0599]: no method named `put` found for reference `&dyn object_store::ObjectStore` in the current scope
+/// --> datafusion/datasource/src/url.rs:993:14
+/// ```
+///
+/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any
+/// `ObjectStore` implementations to resolve the error
+///
+/// ```text
+/// error[E0407]: method `put` is not a member of trait `ObjectStore`
+/// --> datafusion/datasource/src/url.rs:1103:9
+/// |
+/// ```
+///
+/// 3. Convert `ObjectStore::delete` to [`ObjectStore::delete_stream`] (see documentation
+/// on that method for details and examples)
+///
+/// 4. Combine `ObjectStore::copy` and `ObjectStore::copy_if_not_exists` implementations into
+/// [`ObjectStore::copy_opts`] (see documentation on that method for details and examples)
+///
+/// 5. Update `object_store::Error::NotImplemented` to include the name of the missing method
+///
+/// For example, change instances of
+/// ```text
+/// object_store::Error::NotImplemented
+/// ```
+/// to
+/// ```
+/// object_store::Error::NotImplemented {
+/// operation: "put".to_string(),
+/// implementer: "RequestCountingObjectStore".to_string(),
+/// };
+/// ```
+///
+///
Review Comment:
There's an extra blank line here (two consecutive empty doc comment lines). For consistency, consider removing one of the blank lines.
```suggestion
```
##########
src/lib.rs:
##########
@@ -694,6 +694,48 @@ pub type MultipartId = String;
///
/// To automatically detect this issue, use
/// [`#[deny(clippy::missing_trait_methods)]`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_trait_methods).
+///
+/// # Upgrade Guide for 0.13.0
+///
+/// Upgrading to object_store 0.13.0 from an earlier version typically involves:
+///
+/// 1. Add a `use` for [`ObjectStoreExt`] to solve the error
+///
+/// ```text
+/// error[E0599]: no method named `put` found for reference `&dyn object_store::ObjectStore` in the current scope
+/// --> datafusion/datasource/src/url.rs:993:14
+/// ```
+///
+/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any
+/// `ObjectStore` implementations to resolve the error
+///
+/// ```text
+/// error[E0407]: method `put` is not a member of trait `ObjectStore`
+/// --> datafusion/datasource/src/url.rs:1103:9
+/// |
+/// ```
+///
+/// 3. Convert `ObjectStore::delete` to [`ObjectStore::delete_stream`] (see documentation
+/// on that method for details and examples)
+///
+/// 4. Combine `ObjectStore::copy` and `ObjectStore::copy_if_not_exists` implementations into
+/// [`ObjectStore::copy_opts`] (see documentation on that method for details and examples)
+///
+/// 5. Update `object_store::Error::NotImplemented` to include the name of the missing method
+///
+/// For example, change instances of
+/// ```text
+/// object_store::Error::NotImplemented
+/// ```
+/// to
+/// ```
+/// object_store::Error::NotImplemented {
Review Comment:
There's an extra leading space before the code. The line should start with "///" immediately followed by the code without a leading space to maintain consistency with typical Rust doc formatting.
```suggestion
/// object_store::Error::NotImplemented {
```
##########
src/lib.rs:
##########
@@ -694,6 +694,48 @@ pub type MultipartId = String;
///
/// To automatically detect this issue, use
/// [`#[deny(clippy::missing_trait_methods)]`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_trait_methods).
+///
+/// # Upgrade Guide for 0.13.0
+///
+/// Upgrading to object_store 0.13.0 from an earlier version typically involves:
+///
+/// 1. Add a `use` for [`ObjectStoreExt`] to solve the error
+///
+/// ```text
+/// error[E0599]: no method named `put` found for reference `&dyn object_store::ObjectStore` in the current scope
+/// --> datafusion/datasource/src/url.rs:993:14
+/// ```
+///
+/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any
Review Comment:
There's a double space between the closing parenthesis and "from". Should be a single space for consistency.
```suggestion
/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add A "upgrading to 0.13.0" guide in docs [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #584:
URL: https://github.com/apache/arrow-rs-object-store/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org