[jira] [Commented] (FLINK-9464) Clean up pom files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493285#comment-16493285 ] 

ASF GitHub Bot commented on FLINK-9464:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/6093

    [FLINK-9464] Various pom.xml file clean ups

    ## What is the purpose of the change
    
    Various `pom.xml` file clean ups where we remove redundant or unnecessary specifications because they are specified at a higher level.
    
    ## Brief change log
    
    - Removes redundant `maven-jar-plugin` specification from `flink-clients/pom.xml`
    - Removes unnecessary version and scope specification for `flink-test-utils-junit` from `flink-swift-fs-hadoop/pom.xml`, `flink-statebackend-rocksdb/pom.xml`, `flink-json/pom.xml` because this is specified in the parent `pom.xml` dependency management section
    - Remove unnecessary `maven-shade-plugin` version specification from `flink-swift-fs-hadoop/pom.xml` because it is already specified in the parent `pom.xml` file
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink variousFixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6093
    
----
commit 76ec7129c31b71de2a13d4f84e798f35a2d1cf07
Author: Till Rohrmann <tr...@...>
Date:   2018-05-29T07:36:39Z

    [FLINK-9464] Remove duplicate maven-jar-plugin entry in flink-clients pom.xml

commit b482459c89e69cb0f33e6054e81625eb52a06ca4
Author: Till Rohrmann <tr...@...>
Date:   2018-05-29T07:55:28Z

    [FLINK-9464] Remove version and scope from flink-test-utils-junit and maven-shade-plugin in flink-swift-fs-hadoop pom.xml

commit b9fd6cb9bdbd3a24f77ba812930174508fec02a8
Author: Till Rohrmann <tr...@...>
Date:   2018-05-29T07:57:11Z

    [FLINK-9464] Remove version and scope from flink-test-utils-junit dependency in flink-statebackend-rocksdb pom.xml

commit 67a4ece6d47ccb4b98b51580495ca31593e2452d
Author: Till Rohrmann <tr...@...>
Date:   2018-05-29T08:15:56Z

    [FLINK-9464] Remove version and scope from flink-test-utils-junit in flink-json pom.xml

commit e35b62a67e07bb9b37c2cde3ebe2bada921ae57b
Author: Till Rohrmann <tr...@...>
Date:   2018-05-29T08:53:33Z

    [hotfix] Use ConfigConstants.DEFAULT_CHARSET in KvStateRequest
    
    Specify ConfigConstants.DEFAULT_CHARSET when converting a String into bytes and reading
    a String from a byte array.

----


> Clean up pom files
> ------------------
>
>                 Key: FLINK-9464
>                 URL: https://issues.apache.org/jira/browse/FLINK-9464
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> Some of Flink module's {{pom.xml}} files contain unnecessary or redundant information. For example, the {{flink-clients}} {{pom.xml}} specifies twice the {{maven-jar-plugin}} in the build section. Other modules explicitly specify the version and scope of the {{flink-test-utils-junit}} module which is managed by the parent's dependency management section. I propose to clean these things up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)