You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by re...@apache.org on 2025/01/23 14:13:24 UTC
(cloudberry) 04/16: Remove GPDB_12_MERGE_FIXME in ic_tcp.c (#17154)
This is an automated email from the ASF dual-hosted git repository.
reshke pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 43b9ba9a1c8f6da22603a6f0c86127f178e8cd92
Author: xuejing zhao <80...@users.noreply.github.com>
AuthorDate: Wed Mar 6 10:06:11 2024 +0800
Remove GPDB_12_MERGE_FIXME in ic_tcp.c (#17154)
GPDB_12_MERGE_FIXME in ic_tcp.c:
should use WaitEventSetWait() instead of select() following the routine in ic_udpifc.c
The advantage of using WaitEventSetWait instead of select is that we can monitor
the specific waitevent in the pg_stat_activity view.
However, we still have many select() calls in current Greenplum codes, it's no need to
replace all of them with WaitEventSet, Because most of them doesn't benefit much
from pg_stat_activity, keep using select() is good and simple enough.
Therefore, we have decided to simply remove this fixme.
---
contrib/interconnect/tcp/ic_tcp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/contrib/interconnect/tcp/ic_tcp.c b/contrib/interconnect/tcp/ic_tcp.c
index 1c4531dfbe..98314d4b35 100644
--- a/contrib/interconnect/tcp/ic_tcp.c
+++ b/contrib/interconnect/tcp/ic_tcp.c
@@ -2889,10 +2889,6 @@ RecvTupleChunkFromAnyTCP(ChunkTransportState * transportStates,
}
- /*
- * GPDB_12_MERGE_FIXME: should use WaitEventSetWait() instead of
- * select()
- */
/* follow the routine in ic_udpifc.c */
/**
* Notice that: ic-proxy won't get any tuple if ic_proxy_addrs is empty
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org