You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/02 00:08:57 UTC
[kudu-CR] rpc: add a pre-flight check for server GSSAPI setup
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4909
to review the following change.
Change subject: rpc: add a pre-flight check for server GSSAPI setup
......................................................................
rpc: add a pre-flight check for server GSSAPI setup
This adds a pre-flight check that runs when adding an acceptor pool to a
messenger (which indicates that the messenger will act as a server). The
pre-flight check runs through a partial SASL GSSAPI authentication flow
in order to verify that the plugin is set up and a keytab is available.
Tested this manually as well as with a new unit test.
Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
6 files changed, 94 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/4909/1
--
To view, visit http://gerrit.cloudera.org:8080/4909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] rpc: add a pre-flight check for server GSSAPI setup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4909
to look at the new patch set (#2).
Change subject: rpc: add a pre-flight check for server GSSAPI setup
......................................................................
rpc: add a pre-flight check for server GSSAPI setup
This adds a pre-flight check that runs when adding an acceptor pool to a
messenger (which indicates that the messenger will act as a server). The
pre-flight check runs through a partial SASL GSSAPI authentication flow
in order to verify that the plugin is set up and a keytab is available.
Tested this manually as well as with a new unit test.
Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
6 files changed, 94 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/4909/2
--
To view, visit http://gerrit.cloudera.org:8080/4909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] rpc: add a pre-flight check for server GSSAPI setup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: rpc: add a pre-flight check for server GSSAPI setup
......................................................................
rpc: add a pre-flight check for server GSSAPI setup
This adds a pre-flight check that runs when adding an acceptor pool to a
messenger (which indicates that the messenger will act as a server). The
pre-flight check runs through a partial SASL GSSAPI authentication flow
in order to verify that the plugin is set up and a keytab is available.
Tested this manually as well as with a new unit test.
Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Reviewed-on: http://gerrit.cloudera.org:8080/4909
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
6 files changed, 94 insertions(+), 10 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] rpc: add a pre-flight check for server GSSAPI setup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: rpc: add a pre-flight check for server GSSAPI setup
......................................................................
Patch Set 2: Code-Review+2
Carrying over Dan's +2
--
To view, visit http://gerrit.cloudera.org:8080/4909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] rpc: add a pre-flight check for server GSSAPI setup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: rpc: add a pre-flight check for server GSSAPI setup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia26482003144504dee77ffb2e9de7ebe3c1e2e3d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No