[jira] [Commented] (TINKERPOP-1825) Gremlin .NET: Constant() step has incorrect parameter defined

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274301#comment-16274301 ] 

ASF GitHub Bot commented on TINKERPOP-1825:
-------------------------------------------

GitHub user jorgebay opened a pull request:

    https://github.com/apache/tinkerpop/pull/761

    TINKERPOP-1825 Gremlin.Net: fix generation of Constant() and Fold() steps

    https://issues.apache.org/jira/browse/TINKERPOP-1825
    
    Addressed the issue where generic parameter types generated as `object` in Gremlin.Net.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1825

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #761
    
----
commit aa14928245ed98565dcd4e7f6d21b1a573d76a56
Author: Jorge Bay Gondra <jo...@gmail.com>
Date:   2017-12-01T11:52:15Z

    Gremlin.Net: fix generation of Constant() and Fold() steps

----


> Gremlin .NET: Constant() step has incorrect parameter defined
> -------------------------------------------------------------
>
>                 Key: TINKERPOP-1825
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1825
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: dotnet
>    Affects Versions: 3.2.6
>            Reporter: Jorge Bay
>             Fix For: 3.2.7
>
>
> The generated method shows the following C# signature:
> {code:java}
> public GraphTraversal<S, E2> Constant<E2>(object e)
> {code}
> When instead it should be:
> {code:java}
> public GraphTraversal<S, E2> Constant<E2>(E2 e)
> {code}
> https://github.com/apache/tinkerpop/blob/f2b4fb980559c8427fa946ad0d5acb42292a0b70/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs#L423-L427
> This forces the user to specify the type of the parameter, when otherwise it could be inferred.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)