You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by robdouglas <gi...@git.apache.org> on 2014/08/21 01:28:55 UTC
[GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
GitHub user robdouglas opened a pull request:
https://github.com/apache/incubator-streams/pull/71
STREAMS-152 | Added flag that allows us to force the use of whatever con...
...figuration attributes have been set
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robdouglas/incubator-streams STREAMS-152
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit ed695354bd59b30b8d92f98c2a60d0726925be71
Author: Robert Douglas <rd...@w2odigital.com>
Date: 2014-08-20T23:28:08Z
STREAMS-152 | Added flag that allows us to force the use of whatever configuration attributes have been set
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on the pull request:
https://github.com/apache/incubator-streams/pull/71#issuecomment-52944878
:+1: This looks good. Although this code is getting messy. I think we probably want to look to refactoring this code out and creating mapping objects that will allow user to implement how the index/type/id are set. We can create a default one that works the same as it currently does, but allow users to override it with custom ones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on the pull request:
https://github.com/apache/incubator-streams/pull/71#issuecomment-52937214
Responded to code review feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-152 | Added flag that allo...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/71#discussion_r16514241
--- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchPersistWriter.java ---
@@ -146,14 +146,18 @@ public void write(StreamsDatum streamsDatum) {
String index = Optional.fromNullable(
--- End diff --
I would write this as
````
String index = streamsDatum.getMetadata().get("index");
if(index == null || config.getForceUseConfig()) {
index = config.getIndex();
}
````
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---