[GitHub] [fineract] adamsaghy commented on a diff in pull request #3351: FINERACT-1943 Fix submitted on date references

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282900194


##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData interestPosting(final SavingsAccount
                 savingsAccountTransactionType.getValue().longValue(), savingsAccountTransactionType.getCode(),
                 savingsAccountTransactionType.getValue().toString());
         return new SavingsAccountTransactionData(amount.getAmount(), date, savingsAccount.getId(), savingsAccountTransactionEnumData,
-                isReversed, null, isManualTransaction, lienTransaction);
+                isReversed, null, isManualTransaction, lienTransaction, date);

Review Comment:
   Is that mean the transaction date is end of month (31th July) or start of month (1st of Aug)?



##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData interestPosting(final SavingsAccount
                 savingsAccountTransactionType.getValue().longValue(), savingsAccountTransactionType.getCode(),
                 savingsAccountTransactionType.getValue().toString());
         return new SavingsAccountTransactionData(amount.getAmount(), date, savingsAccount.getId(), savingsAccountTransactionEnumData,
-                isReversed, null, isManualTransaction, lienTransaction);
+                isReversed, null, isManualTransaction, lienTransaction, date);

Review Comment:
   Does that mean the transaction date is end of month (31th July) or start of month (1st of Aug)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org