You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/11 23:38:19 UTC
[jira] [Commented] (FELIX-4009) maven bundle plugin should be
integrated directly with eclipse
[ https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191618#comment-15191618 ]
ASF GitHub Bot commented on FELIX-4009:
---------------------------------------
GitHub user stefanseifert opened a pull request:
https://github.com/apache/felix/pull/57
FELIX-4009 maven bundle plugin should be integrated directly with eclipse
define m2e lifecycle mapping metadata, enable incremental build for manifest (and SCR metadata) generation - important for unit tests e.g. with sling/osgi-mock
make sure all files that are written use file output streams created via BuildContext to make sure eclipse get notice of it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stefanseifert/felix feature/FELIX-4009_maven-bundle-m2e
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit 2d21b56e76ac89b95492c606046d1070e9e92f88
Author: sseifert <ss...@pro-vision.de>
Date: 2016-03-11T17:54:53Z
FELIX-4009 maven bundle plugin should be integrated directly with eclipse
define m2e lifecycle mapping metadata, enable incremental build for manifest (and SCR metadata) generation - important for unit tests e.g. with sling/osgi-mock
make sure all files that are written use file output streams created via BuildContext to make sure eclipse get notice of it
----
> maven bundle plugin should be integrated directly with eclipse
> --------------------------------------------------------------
>
> Key: FELIX-4009
> URL: https://issues.apache.org/jira/browse/FELIX-4009
> Project: Felix
> Issue Type: New Feature
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.7
> Reporter: Andrei Pozolotin
> Labels: m2e
> Fix For: maven-bundle-plugin-future
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with eclipse via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin
> thanks.
> Andrei.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)