You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/20 02:47:42 UTC

[kudu-CR] Upgrade gperftools to 2.6.90

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9721

to review the following change.


Change subject: Upgrade gperftools to 2.6.90
......................................................................

Upgrade gperftools to 2.6.90

2.6.90 is a release candidate for 2.7. It contains basically the same
bits that we are already using plus another small patch that I wrote
upstream that might make 1MB allocations slightly more efficient.

Change-Id: I62d832801160b25952669b7f4b49f5501bf0b112
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-Implemented-O-log-n-searching-among-large-spans.patch
M thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch
D thirdparty/patches/gperftools-sized-alloc-build-fix.patch
M thirdparty/vars.sh
5 files changed, 20 insertions(+), 596 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/9721/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62d832801160b25952669b7f4b49f5501bf0b112
Gerrit-Change-Number: 9721
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] Upgrade gperftools to 2.6.90

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9721 )

Change subject: Upgrade gperftools to 2.6.90
......................................................................

Upgrade gperftools to 2.6.90

2.6.90 is a release candidate for 2.7. It contains basically the same
bits that we are already using plus another small patch that I wrote
upstream that might make 1MB allocations slightly more efficient.

Change-Id: I62d832801160b25952669b7f4b49f5501bf0b112
Reviewed-on: http://gerrit.cloudera.org:8080/9721
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-Implemented-O-log-n-searching-among-large-spans.patch
M thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch
D thirdparty/patches/gperftools-sized-alloc-build-fix.patch
M thirdparty/vars.sh
5 files changed, 20 insertions(+), 596 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62d832801160b25952669b7f4b49f5501bf0b112
Gerrit-Change-Number: 9721
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Upgrade gperftools to 2.6.90

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9721 )

Change subject: Upgrade gperftools to 2.6.90
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62d832801160b25952669b7f4b49f5501bf0b112
Gerrit-Change-Number: 9721
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 20 Mar 2018 06:49:58 +0000
Gerrit-HasComments: No