You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/12/17 23:54:23 UTC

[incubator-superset] 01/02: git status

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/ch229
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 8f957dc1e3bb62fd1a8c7ad33b404829fcaeb183
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Dec 17 18:45:46 2020 -0500

    git status
---
 .../src/SqlLab/components/RunQueryActionButton.tsx | 23 +++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx b/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
index 8b2cad4..d733465 100644
--- a/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
+++ b/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
@@ -66,9 +66,20 @@ const RunQueryActionButton = ({
 
   if (shouldShowStopBtn) {
     return (
-      <Button {...commonBtnProps} cta onClick={stopQuery}>
+      <>
+        {/* <Button {...commonBtnProps} cta onClick={stopQuery}>
         <i className="fa fa-stop" /> {t('Stop')}
-      </Button>
+      </Button> */}
+      <Dropdown.Button
+          onClick={stopQuery}
+          icon={<Icon color="#00000" name="caret-down" />}
+          type="primary"
+          overlay={overlayCreateAsMenu}
+          disabled={!sql.trim()}
+        >
+          <i className="fa fa-stop" /> {t('Stop')}
+        </Dropdown.Button>
+      </>
     );
   }
   if (allowAsync) {
@@ -86,11 +97,12 @@ const RunQueryActionButton = ({
         </Button> */}
         <Dropdown.Button
           onClick={() => runQuery(true)}
-          icon={<Icon color="#00000a" name="caret-down" />}
+          icon={<Icon color="#00000" name="caret-down" />}
           type="primary"
           overlay={overlayCreateAsMenu}
+          disabled={!sql.trim()}
         >
-          Run
+          <i className="fa fa-bolt" /> {runBtnText}
         </Dropdown.Button>
       </>
     );
@@ -112,8 +124,9 @@ const RunQueryActionButton = ({
         icon={<Icon color="#00000" name="caret-down" />}
         type="primary"
         overlay={overlayCreateAsMenu}
+        disabled={!sql.trim()}
       >
-        Run
+        <i className="fa fa-refresh" /> {runBtnText}
       </Dropdown.Button>
     </>
   );