You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/09 10:40:39 UTC
[GitHub] [airflow] tiago-palma opened a new pull request #10826: Add prerequisite to add-dag-tags documentation
tiago-palma opened a new pull request #10826:
URL: https://github.com/apache/airflow/pull/10826
Add a UI prerequisite section explaining that RBAC needs to be enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10826: Add prerequisite to add-dag-tags documentation
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10826:
URL: https://github.com/apache/airflow/pull/10826#issuecomment-689868178
on the master branch, we develop Airfllow, 2.0. In dropped support for non RBAC UI, so this information is no longer applicable. Can you create a new PR that target to v1-10-test brsncj?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10826: Add prerequisite to add-dag-tags documentation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10826:
URL: https://github.com/apache/airflow/pull/10826#issuecomment-689478937
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tiago-palma commented on pull request #10826: Add prerequisite to add-dag-tags documentation
Posted by GitBox <gi...@apache.org>.
tiago-palma commented on pull request #10826:
URL: https://github.com/apache/airflow/pull/10826#issuecomment-690010704
OK. I will close this PR in favor of this new one https://github.com/apache/airflow/pull/10852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tiago-palma closed pull request #10826: Add prerequisite to add-dag-tags documentation
Posted by GitBox <gi...@apache.org>.
tiago-palma closed pull request #10826:
URL: https://github.com/apache/airflow/pull/10826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org