[GitHub] [incubator-mxnet] szha commented on a change in pull request #14900: Fix warning / static function in header.

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #14900: Fix warning / static function in header.
URL: https://github.com/apache/incubator-mxnet/pull/14900#discussion_r287058080
 
 

 ##########
 File path: src/operator/nn/dropout.cc
 ##########
 @@ -26,6 +26,32 @@
 
 #include "./dropout-inl.h"
 #include "../operator_common.h"
+#include "mxnet/op_attr_types.h"
+
+namespace {
+
+using namespace mxnet;
+using namespace mxnet::op;
 
 Review comment:
   @larroy @haojin2 
   1. Every time a build request is sent to the CI it costs, a lot. It would be great if we all could be mindful about it when organizing PRs. We trust people to use the best judgment.
   2. While I fully trust that it's not @larroy's intention to send duplicate PRs, I'd like to make it clear why requesters should not file duplicate PRs. While it hasn't been an issue so far, I think we all can see how that can be used to circumvent vetos from committers. Allowing duplicate PRs would thus defeat the purpose of the veto rights in an Apache community.
   
   Feel free to bring the discussion to dev@ if you're still in doubt.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services