Re: CVS update: subversion/subversion/tests/libsvn_wc commit-test.c

[Greg Stein <gs...@lyra.org>]

On Thu, Apr 12, 2001 at 08:02:39AM -0000, cmpilato@tigris.org wrote:
>...
>     (svn_pool_destroy): New abstraction for apr_pool_destroy.

This seems a bit wacky. Just why do we have this? The function doesn't do
anything. And making people thing about a different function just leads them
to "what does this do?" And the answer is "nothing special"

What next? svn_pool_clear?

If svn_pool_destroy is not going to add any semantic value, then we should
not add the burden of its use.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: CVS update: subversion/subversion/tests/libsvn_wc commit-test.c

[cm...@collab.net]

Greg Stein <gs...@lyra.org> writes:

> If svn_pool_destroy is not going to add any semantic value, then we should
> not add the burden of its use.

Easy there, cowboy -- I had a reason.  See following commits, THEN
fuss. :-)  

Oh, and svn_pool_clear already exists. (shrug)