You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2016/01/21 23:27:15 UTC

Review Request 42619: move public kv api from samza-kv to samza-api package

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42619/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-861
    https://issues.apache.org/jira/browse/SAMZA-861


Repository: samza


Description
-------

move public kv api from samza-kv to samza-api package


Diffs
-----

  samza-kv/src/main/java/org/apache/samza/storage/kv/Entry.java  
  samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueIterator.java  
  samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java  

Diff: https://reviews.apache.org/r/42619/diff/


Testing
-------


Thanks,

Boris Shkolnik


Re: Review Request 42619: move public kv api from samza-kv to samza-api package

Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42619/#review116220
-----------------------------------------------------------


Ship it!




Ship It!

- Yi Pan (Data Infrastructure)


On Jan. 21, 2016, 10:27 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42619/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 10:27 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-861
>     https://issues.apache.org/jira/browse/SAMZA-861
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> move public kv api from samza-kv to samza-api package
> 
> 
> Diffs
> -----
> 
>   samza-kv/src/main/java/org/apache/samza/storage/kv/Entry.java  
>   samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueIterator.java  
>   samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java  
> 
> Diff: https://reviews.apache.org/r/42619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>


Re: Review Request 42619: move public kv api from samza-kv to samza-api package

Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42619/#review115794
-----------------------------------------------------------

Ship it!


LGTM

- Jagadish Venkatraman


On Jan. 21, 2016, 10:27 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42619/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 10:27 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-861
>     https://issues.apache.org/jira/browse/SAMZA-861
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> move public kv api from samza-kv to samza-api package
> 
> 
> Diffs
> -----
> 
>   samza-kv/src/main/java/org/apache/samza/storage/kv/Entry.java  
>   samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueIterator.java  
>   samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java  
> 
> Diff: https://reviews.apache.org/r/42619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>