You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/02/10 01:25:08 UTC

[GitHub] [pulsar-site] tisonkun opened a new pull request, #405: Fix set-persistent admin doc

tisonkun opened a new pull request, #405:
URL: https://github.com/apache/pulsar-site/pull/405

   This supersedes https://github.com/apache/pulsar/pull/19001.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] Anonymitaet commented on pull request #405: Fix set-persistent admin doc

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425062817

   @tjiuming PTAL, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] Anonymitaet commented on pull request #405: Fix set-persistent admin doc

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425078826

   Hi @tisonkun, we (@hangc0276 @codelipenghui) have confirmed that this should be added to these 3 versions of docs. 
   
   Code will be cherry-picked later.
   
   
   <img width="1379" alt="image" src="https://user-images.githubusercontent.com/50226895/217982166-6509ca10-e603-44c8-8ee2-c07754212c27.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] Anonymitaet commented on pull request #405: Fix set-persistent admin doc

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425127142

   We can tag this PR with the same labels and add docs to 2.9.x, 2.10.x, 2.11.x after those versions are released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #405: Fix set-persistent admin doc

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425080757

   @Anonymitaet Thanks for your information.
   
   Let's think of the change: the change commit to doc site will be published immediately, while the patch release will be out weeks or months later. It may not be a good idea to include changes to those versions now, but it helps we share information here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #405: Fix set-persistent admin doc

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425064565

   One important issue that what versions are affected. From https://github.com/apache/pulsar/pull/18999 I can see only the NEXT version (3.0.0) is affected. Please confirm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tjiuming commented on pull request #405: Fix set-persistent admin doc

Posted by "tjiuming (via GitHub)" <gi...@apache.org>.
tjiuming commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1425141557

   The code PR tagged with 2.9 2.10 2.11, I think keep align with it will be fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #405: Fix set-persistent admin doc

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #405:
URL: https://github.com/apache/pulsar-site/pull/405#issuecomment-1426023422

   Updated. Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun merged pull request #405: Fix set-persistent admin doc

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #405:
URL: https://github.com/apache/pulsar-site/pull/405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org