[jira] [Issue Comment Deleted] (MESOS-3329) Unused hashmap::existsValue functions have incomplete code paths

["Jian Qiu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jian Qiu updated MESOS-3329:
----------------------------
    Comment: was deleted

(was: commit 7ef97970ae4d5ea909abbf234a565ae7db62b192
Author: Jian Qiu <qi...@cn.ibm.com>
Date:   Mon Aug 31 21:28:34 2015 +0800

    Remove hashmap::existsValue since it is never called

    Review: https://reviews.apache.org/r/37955
)

> Unused hashmap::existsValue functions have incomplete code paths
> ----------------------------------------------------------------
>
>                 Key: MESOS-3329
>                 URL: https://issues.apache.org/jira/browse/MESOS-3329
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Jan Schlicht
>            Assignee: Jian Qiu
>            Priority: Trivial
>              Labels: easyfix, mesosphere
>
> `stout/hashmap.hpp` defines functions `hashmap::existsValue`. These return true if a certain value exists in the hashmap instance. The control flow of these functions doesn't cover the case that the value is not found, which should result in false. Right now the result in this case is undefined.
> As the `existsValue` functions are never called this doesn't result in a compile error atm.
> Possible solutions:
> 1) Add `return false`
> 2) Remove function



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)