You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Colin Crist <co...@hermesjms.com> on 2006/09/04 12:37:00 UTC

Couple of minor patches, qpid-server.bat and AMQConnectionFactory.java

 
Hi,
 
Could someone review and apply these patches? I need the second one for QPID
to work with HermesJMS.
 
Regards,
 
Colin.
http://hermesjms.com
 
1. /etp/blaze/java/broker/bin/qpid-server.bat:
 
Index: qpid-server.bat
===================================================================
--- qpid-server.bat (revision 402)
+++ qpid-server.bat (working copy)
@@ -48,7 +48,6 @@
 
 set LAUNCH_JAR=%QPID_HOME%\lib\broker-launch.jar
 set MODULE_JARS=%QPID_HOME%\lib\bdbstore-launch.jar
-%JAVA_HOME%\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
-"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
+"%JAVA_HOME%"\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
 
 :end
 
2.
etp/blaze/java/client/src/org/apache/qpid/client/AMQConnectionFactory.java
 
c:/work/svn-projects/etp/blaze/java/client/src/org/apache/qpid/client $ svn
diff
Index: AMQConnectionFactory.java
===================================================================
--- AMQConnectionFactory.java (revision 402)
+++ AMQConnectionFactory.java (working copy)
@@ -41,6 +41,10 @@
     private ConnectionURL _connectionDetails;
 
 
+    public AMQConnectionFactory()
+    {
+    }
+
     public AMQConnectionFactory(String url)
     {
         _connectionDetails = new AMQConnectionURL(url);
@@ -75,6 +79,11 @@
         _defaultPassword = password;
     }
 
+    public final String getDefaultPassword()
+    {
+ return _defaultPassword ;
+    }
+
     /**
      * @param username The _defaultUsername to set.
      */
@@ -83,6 +92,11 @@
         _defaultUsername = username;
     }
 
+    public final String getDefaultUsername()
+    {
+ return _defaultUsername ;
+    }
+
     /**
      * @param _host The _host to set.
      */
@@ -91,6 +105,11 @@
         this._host = _host;
     }
 
+    public final String getHost()
+    {
+ return _host ;
+    }
+
     /**
      * @param _port The _port to set.
      */
@@ -99,6 +118,11 @@
         this._port = _port;
     }
 
+    public final int getPort()
+    {
+ return _port ;
+    }
+
     /**
      * @param path The _virtualPath to set.
      */
@@ -107,6 +131,11 @@
         _virtualPath = path;
     }
 
+    public final String getVirtualPath()
+    {
+ return _virtualPath ;
+    }
+
     static String getUniqueClientID()
 
 

RE: Couple of minor patches, qpid-server.bat and AMQConnectionFactory.java

Posted by Colin Crist <co...@hermesjms.com>.

Martin,

Thanks - I'll try it out later.

I guess there should be a set/getConnectionURL too?

Regards,

Colin.
http://hermesjms.com 

-----Original Message-----
From: Martin Ritchie [mailto:martin.a.ritchie@jpmorgan.com] 
Sent: 04 September 2006 14:30
To: qpid-dev@incubator.apache.org
Cc: dev@etp.108.redhat.com
Subject: Re: Couple of minor patches, qpid-server.bat and
AMQConnectionFactory.java

Colin,

I have applied these two patches. 

There is one outstanding issue:

Currently the Host and Port values can only be changed programmatically if
you do not use a Connection URL. This is because there may be more than one
host-port combination.

Cheers


Martin 






"Colin Crist" <co...@hermesjms.com>
2006-09-04 11:37
Please respond to qpid-dev
 
        To:     <qp...@incubator.apache.org>, <de...@etp.108.redhat.com>
        cc: 
        Subject:        Couple of minor patches, qpid-server.bat and 
AMQConnectionFactory.java


 
Hi,
 
Could someone review and apply these patches? I need the second one for QPID
to work with HermesJMS.
 
Regards,
 
Colin.
http://hermesjms.com
 
1. /etp/blaze/java/broker/bin/qpid-server.bat:
 
Index: qpid-server.bat
===================================================================
--- qpid-server.bat (revision 402)
+++ qpid-server.bat (working copy)
@@ -48,7 +48,6 @@
 
 set LAUNCH_JAR=%QPID_HOME%\lib\broker-launch.jar
 set MODULE_JARS=%QPID_HOME%\lib\bdbstore-launch.jar
-%JAVA_HOME%\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
-"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
+"%JAVA_HOME%"\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
 
 :end
 
2.
etp/blaze/java/client/src/org/apache/qpid/client/AMQConnectionFactory.java
 
c:/work/svn-projects/etp/blaze/java/client/src/org/apache/qpid/client $ svn
diff
Index: AMQConnectionFactory.java
===================================================================
--- AMQConnectionFactory.java (revision 402)
+++ AMQConnectionFactory.java (working copy)
@@ -41,6 +41,10 @@
     private ConnectionURL _connectionDetails;
 
 
+    public AMQConnectionFactory()
+    {
+    }
+
     public AMQConnectionFactory(String url)
     {
         _connectionDetails = new AMQConnectionURL(url); @@ -75,6 +79,11 @@
         _defaultPassword = password;
     }
 
+    public final String getDefaultPassword()
+    {
+ return _defaultPassword ;
+    }
+
     /**
      * @param username The _defaultUsername to set.
      */
@@ -83,6 +92,11 @@
         _defaultUsername = username;
     }
 
+    public final String getDefaultUsername()
+    {
+ return _defaultUsername ;
+    }
+
     /**
      * @param _host The _host to set.
      */
@@ -91,6 +105,11 @@
         this._host = _host;
     }
 
+    public final String getHost()
+    {
+ return _host ;
+    }
+
     /**
      * @param _port The _port to set.
      */
@@ -99,6 +118,11 @@
         this._port = _port;
     }
 
+    public final int getPort()
+    {
+ return _port ;
+    }
+
     /**
      * @param path The _virtualPath to set.
      */
@@ -107,6 +131,11 @@
         _virtualPath = path;
     }
 
+    public final String getVirtualPath()
+    {
+ return _virtualPath ;
+    }
+
     static String getUniqueClientID()
 
 




This communication is for informational purposes only. It is not intended as
an offer or solicitation for the purchase or sale of any financial
instrument or as an official confirmation of any transaction. All market
prices, data and other information are not warranted as to completeness or
accuracy and are subject to change without notice. Any comments or
statements made herein do not necessarily reflect those of JPMorgan Chase &
Co., its subsidiaries and affiliates.

This transmission may contain information that is privileged, confidential,
legally privileged, and/or exempt from disclosure under applicable law. If
you are not the intended recipient, you are hereby notified that any
disclosure, copying, distribution, or use of the information contained
herein (including any reliance thereon) is STRICTLY PROHIBITED. Although
this transmission and any attachments are believed to be free of any virus
or other defect that might affect any computer system into which it is
received and opened, it is the responsibility of the recipient to ensure
that it is virus free and no responsibility is accepted by JPMorgan Chase &
Co., its subsidiaries and affiliates, as applicable, for any loss or damage
arising in any way from its use. If you received this transmission in error,
please immediately contact the sender and destroy the material in its
entirety, whether in electronic or hard copy format. Thank you.
 





Re: Couple of minor patches, qpid-server.bat and AMQConnectionFactory.java

Posted by Martin Ritchie <ma...@jpmorgan.com>.
Colin,

I have applied these two patches. 

There is one outstanding issue:

Currently the Host and Port values can only be changed programmatically if 
you do not use a Connection URL. This is because there may be more than 
one host-port combination.

Cheers


Martin 






"Colin Crist" <co...@hermesjms.com>
2006-09-04 11:37
Please respond to qpid-dev
 
        To:     <qp...@incubator.apache.org>, <de...@etp.108.redhat.com>
        cc: 
        Subject:        Couple of minor patches, qpid-server.bat and 
AMQConnectionFactory.java


 
Hi,
 
Could someone review and apply these patches? I need the second one for 
QPID
to work with HermesJMS.
 
Regards,
 
Colin.
http://hermesjms.com
 
1. /etp/blaze/java/broker/bin/qpid-server.bat:
 
Index: qpid-server.bat
===================================================================
--- qpid-server.bat (revision 402)
+++ qpid-server.bat (working copy)
@@ -48,7 +48,6 @@
 
 set LAUNCH_JAR=%QPID_HOME%\lib\broker-launch.jar
 set MODULE_JARS=%QPID_HOME%\lib\bdbstore-launch.jar
-%JAVA_HOME%\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
-"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
+"%JAVA_HOME%"\bin\java -server -Xmx1024m -DQPID_HOME="%QPID_HOME%" -cp
"%LAUNCH_JAR%;%MODULE_JARS%" org.apache.qpid.server.Main *
 
 :end
 
2.
etp/blaze/java/client/src/org/apache/qpid/client/AMQConnectionFactory.java
 
c:/work/svn-projects/etp/blaze/java/client/src/org/apache/qpid/client $ 
svn
diff
Index: AMQConnectionFactory.java
===================================================================
--- AMQConnectionFactory.java (revision 402)
+++ AMQConnectionFactory.java (working copy)
@@ -41,6 +41,10 @@
     private ConnectionURL _connectionDetails;
 
 
+    public AMQConnectionFactory()
+    {
+    }
+
     public AMQConnectionFactory(String url)
     {
         _connectionDetails = new AMQConnectionURL(url);
@@ -75,6 +79,11 @@
         _defaultPassword = password;
     }
 
+    public final String getDefaultPassword()
+    {
+ return _defaultPassword ;
+    }
+
     /**
      * @param username The _defaultUsername to set.
      */
@@ -83,6 +92,11 @@
         _defaultUsername = username;
     }
 
+    public final String getDefaultUsername()
+    {
+ return _defaultUsername ;
+    }
+
     /**
      * @param _host The _host to set.
      */
@@ -91,6 +105,11 @@
         this._host = _host;
     }
 
+    public final String getHost()
+    {
+ return _host ;
+    }
+
     /**
      * @param _port The _port to set.
      */
@@ -99,6 +118,11 @@
         this._port = _port;
     }
 
+    public final int getPort()
+    {
+ return _port ;
+    }
+
     /**
      * @param path The _virtualPath to set.
      */
@@ -107,6 +131,11 @@
         _virtualPath = path;
     }
 
+    public final String getVirtualPath()
+    {
+ return _virtualPath ;
+    }
+
     static String getUniqueClientID()
 
 




This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates.

This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you.