You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/30 06:38:33 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
mattisonchao opened a new pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060
### Motivation
Fixes ``AsyncResponse``does not resume when redirected.
### Modifications
- Add ``AsyncResponse#resume`` when redirected.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1031618909
@lhotari - this bug appears to be introduced in #13805, which has not yet made it into a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1031175264
> @lhotari You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect to another broker.
I'm sorry I missed that detail. I wonder if there are other problems that this PR fixes?
The fix is to production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1031178398
Would it be possible to add more test coverage that the missing redirect would be caught by a unit test or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1032231243
I think if we add a test for the admin side to test topic not own this broker will redirect to another broker action. maybe we need to add this test for all admin APIs that need to validate topic ownership, So, I think it needs a lot of work. ant I think we need to do it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1025094247
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1030489118
@merlimat @lhotari @Jason918 PTAL :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1025105089
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1030610732
> Change looks good, but would you be able to describe what kind of issues this caused? What was the end user impact? Any sample error logs? That could help find out if a particular problems is fixed by this change.
You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect to another broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1030610732
> Change looks good, but would you be able to describe what kind of issues this caused? What was the end user impact? Any sample error logs? That could help find out if a particular problems is fixed by this change.
You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1031194295
> Would it be possible to add more test coverage that the missing redirect would be caught by a unit test or similar?
Sure, i will do it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on pull request #14060: [Issue 14046] Fixes ``AsyncResponse``does not resume when redirected.
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on pull request #14060:
URL: https://github.com/apache/pulsar/pull/14060#issuecomment-1030610732
> Change looks good, but would you be able to describe what kind of issues this caused? What was the end user impact? Any sample error logs? That could help find out if a particular problems is fixed by this change.
@lhotari You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect to another broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org