[GitHub] [netbeans] jlahoda commented on pull request #5550: Adding support for JDK 20 javac.

["jlahoda (via GitHub)" <gi...@apache.org>]

jlahoda commented on PR #5550:
URL: https://github.com/apache/netbeans/pull/5550#issuecomment-1441897362

   > > This nb-javac build also removes the javac backports (https://github.com/JaroslavTulach/nb-javac/pull/16/files). Since arm block formatting tests didn't fail it appears everything is still working :)
   > 
   > Well, we don't have an arm block formatting test that's sensitive to the fix AFAIK - possibly one with `var` judging by #5546 ? I wonder if line breaks now work correctly too?!
   
   FWIW, there is yours:
   https://github.com/apache/netbeans/commit/8f536817b5ebc19c4844f8819344b498a6f334c6
   
   I've added another when the type if `var`, and removed what I believe was the workaround for the old positions, alongside with the version updates suggested by Michael.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists