You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/07/10 02:09:28 UTC
[GitHub] zeppelin pull request #3059: ZEPPELIN-3595. Remove interpreter binding in ba...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3059
ZEPPELIN-3595. Remove interpreter binding in backend
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3059
----
commit 5eb946e5a559f85cfed20c72f3c1e0a77c43b121
Author: Jeff Zhang <zj...@...>
Date: 2018-07-09T09:22:18Z
ZEPPELIN-3595. Remove interpreter binding in backend
----
---
[GitHub] zeppelin issue #3059: ZEPPELIN-3595. Remove interpreter binding in backend
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3059
@felixcheung @jongyoul pr #3103 will fix the default interpreter issue.
---
[GitHub] zeppelin pull request #3059: ZEPPELIN-3595. Remove interpreter binding in ba...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3059
---
[GitHub] zeppelin issue #3059: ZEPPELIN-3595. Remove interpreter binding in backend
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3059
@jongyoul I like the idea of having a default interpreter (and not a default interpreter group ) **per note**.
+1
---
[GitHub] zeppelin issue #3059: ZEPPELIN-3595. Remove interpreter binding in backend
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3059
Will merge it if no more comments
---
[GitHub] zeppelin issue #3059: ZEPPELIN-3595. Remove interpreter binding in backend
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3059
@felixcheung It's not for now if you set `spark interpreter group` as the first interpreter group in your `zeppelin-site.xml`. I think it needs more implementation even in front side as well to keep the default interpreter setting per note. We need to know whole plan to remove interpreter binding option
---
[GitHub] zeppelin issue #3059: ZEPPELIN-3595. Remove interpreter binding in backend
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3059
Five hundred lines' difficult and sophisticated code will be removed. :-)
---