You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 22:57:29 UTC
Review Request 71509: Windows: Fixed
AllocationRoleEnvironmentVariable tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71509/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Till Toenshoff.
Bugs: MESOS-9874
https://issues.apache.org/jira/browse/MESOS-9874
Repository: mesos
Description
-------
These tests were using a shell script, which can easily be
converted to a batch script on Windows.
Diffs
-----
src/tests/command_executor_tests.cpp e9726b0b6c4623d5196186cd43722952f77669da
src/tests/containerizer/docker_containerizer_tests.cpp 5e31a95149bdc0de64eeab3c289f7816077c82c4
src/tests/default_executor_tests.cpp e5c0bf2df4b35fb3920104e1b72bea7797724933
Diff: https://reviews.apache.org/r/71509/diff/1/
Testing
-------
cmake --build . --target check (Windows)
Thanks,
Joseph Wu
Re: Review Request 71509: Windows: Fixed
AllocationRoleEnvironmentVariable tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71509/#review217837
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 18, 2019, 3:57 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71509/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2019, 3:57 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Till Toenshoff.
>
>
> Bugs: MESOS-9874
> https://issues.apache.org/jira/browse/MESOS-9874
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a shell script, which can easily be
> converted to a batch script on Windows.
>
>
> Diffs
> -----
>
> src/tests/command_executor_tests.cpp e9726b0b6c4623d5196186cd43722952f77669da
> src/tests/containerizer/docker_containerizer_tests.cpp 5e31a95149bdc0de64eeab3c289f7816077c82c4
> src/tests/default_executor_tests.cpp e5c0bf2df4b35fb3920104e1b72bea7797724933
>
>
> Diff: https://reviews.apache.org/r/71509/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target check (Windows)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71509: Windows: Fixed
AllocationRoleEnvironmentVariable tests.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71509/#review217836
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 18, 2019, 10:57 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71509/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2019, 10:57 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Till Toenshoff.
>
>
> Bugs: MESOS-9874
> https://issues.apache.org/jira/browse/MESOS-9874
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were using a shell script, which can easily be
> converted to a batch script on Windows.
>
>
> Diffs
> -----
>
> src/tests/command_executor_tests.cpp e9726b0b6c4623d5196186cd43722952f77669da
> src/tests/containerizer/docker_containerizer_tests.cpp 5e31a95149bdc0de64eeab3c289f7816077c82c4
> src/tests/default_executor_tests.cpp e5c0bf2df4b35fb3920104e1b72bea7797724933
>
>
> Diff: https://reviews.apache.org/r/71509/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target check (Windows)
>
>
> Thanks,
>
> Joseph Wu
>
>