You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/04/30 00:37:49 UTC
[jira] [Commented] (RAVE-586) Break out the navbar
[ https://issues.apache.org/jira/browse/RAVE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264633#comment-13264633 ]
jiraposter@reviews.apache.org commented on RAVE-586:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4930/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Refactored the common navbar components to the header.tag file and included that in all relevant jsp files (except mobile). I also expanded the NavigationItem code to handle parameters for the navigation item text. Moved menu generation code to the ControllerUtils class. This should eventually be loaded from a DB per ticket RAVE-589
This addresses bug RAVE-586.
https://issues.apache.org/jira/browse/RAVE-586
Diffs
-----
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java 1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1331506
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java 1331506
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationItemTest.java 1331506
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationMenuTest.java 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1331506
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag 1331506
Diff: https://reviews.apache.org/r/4930/diff
Testing
-------
Went through all screens to verify items showed as expected and had the correct links.
Thanks,
Chris
> Break out the navbar
> --------------------
>
> Key: RAVE-586
> URL: https://issues.apache.org/jira/browse/RAVE-586
> Project: Rave
> Issue Type: Sub-task
> Components: rave-portal
> Reporter: Chris Geer
>
> Break out the navbar (bar along the top)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira