[GitHub] [accumulo] EdColeman commented on a change in pull request #2467: Added mechanism to cancel FaTE operations from Shell with Manager up

[GitBox <gi...@apache.org>]

EdColeman commented on a change in pull request #2467:
URL: https://github.com/apache/accumulo/pull/2467#discussion_r800780155



##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java
##########
@@ -136,7 +140,29 @@ public int execute(final String fullCommand, final CommandLine cl, final Shell s
         getZooReaderWriter(context, siteConfig, cl.getOptionValue(secretOption.getOpt()));
     ZooStore<FateCommand> zs = new ZooStore<>(path, zk);
 
-    if ("fail".equals(cmd)) {
+    if ("fail-live".equals(cmd)) {

Review comment:
       I do not know if there is a nuance with cancel vs. fail.  Cancel seems (to me) a more normal operation - I changed my mind. Fail seems more of an error condition.  The documentation in the FATE section states that  "Failing an operation is not a normal procedure" Does canceling a compaction raise to that level?  So either way fail / or cancel, but it maybe worth considering the context and usage.   
   
   One one hand, not needing to remember when its fail vs. cancel (follow existing naming) is a positive - unless cancel is more "normal" and does not take a lot of insight for an operator to execute.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org