[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063#discussion_r1191262539


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -370,10 +370,13 @@ public CompletableFuture<Integer> createZone(DistributionZoneConfigurationParame
                         }
 
                         if (distributionZoneCfg.dataNodesAutoAdjustScaleUp() == null) {
-                            zoneChange.changeDataNodesAutoAdjustScaleUp(INFINITE_TIMER_VALUE);
+                            if (distributionZoneCfg.dataNodesAutoAdjust() == null) {
+                                zoneChange.changeDataNodesAutoAdjustScaleUp(IMMEDIATE_TIMER_VALUE);

Review Comment:
   Do we really need it? Seems that we shouldn't manually set default value specified in DistributionZoneConfigurationSchema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org