You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "seongjinyoon (via GitHub)" <gi...@apache.org> on 2025/10/02 02:40:23 UTC
[I] Delete button of edges doesn't work [texera]
seongjinyoon opened a new issue, #3805:
URL: https://github.com/apache/texera/issues/3805
https://github.com/user-attachments/assets/ea0f1875-a661-4781-80b2-a3fab0ae7f00
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Delete button of edges doesn't work [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on issue #3805:
URL: https://github.com/apache/texera/issues/3805#issuecomment-3362281412
@Ma77Ball Thanks for the comments. We need an end-to-end framework that can test both the frontend and the backend. It will take effort to develop this testing framework. Meanwhile, @Ma77Ball and @aglinxinyuan, let's learn the lesson and try to avoid similar mistakes in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Delete button of edges doesn't work [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on issue #3805:
URL: https://github.com/apache/texera/issues/3805#issuecomment-3362181014
The delete button does work, it is just that it is only clickable from the outer ring. This is a styling issue I fixed in this pr: https://github.com/apache/texera/pull/3809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Delete button of edges doesn't work [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on issue #3805:
URL: https://github.com/apache/texera/issues/3805#issuecomment-3362259518
Overall, PR #3602 introduced the bug, as we had to switch how we generated the delete button from a joint.linktools.button to allow it to be moved freely on the link between operators. This meant that to add the original shape of the delete button, the style had to be regenerated. In that process, the fill had to be set to none, but because it was set to none, there was no clickable element. I'm not sure of an automated way to prevent this, as it is a ui issue. The best prevention is to physically test ui prs, as there aren't any test cases that can account for issues like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Delete button of edges doesn't work [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on issue #3805:
URL: https://github.com/apache/texera/issues/3805#issuecomment-3358904264
@Ma77Ball Can you check if this issue is related to your recent PR https://github.com/apache/texera/pull/3602?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Delete button of edges doesn't work [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #3805: Delete button of edges doesn't work
URL: https://github.com/apache/texera/issues/3805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org