You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2007/05/16 22:36:16 UTC

[jira] Commented: (HADOOP-1356) ValueHistogram.addNextValue(Object) ignores return value of String.substring(int, int)

    [ https://issues.apache.org/jira/browse/HADOOP-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496402 ] 

Hadoop QA commented on HADOOP-1356:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12357495/patch-1356.txt applied and successfully tested against trunk revision r538704.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/149/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/149/console

> ValueHistogram.addNextValue(Object) ignores return value of String.substring(int, int)
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1356
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Runping Qi
>            Priority: Blocker
>             Fix For: 0.13.0
>
>         Attachments: patch-1356.txt
>
>
> ValueHistogram.java line 54
> The String.substring method doesn't update the object it operates on.  Instead, it returns a new String object.  This return value is ignored, which must be a bug. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.