You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/12/08 17:33:01 UTC
Review Request 54538: WIP: Enabled fine grained authorization for the
getContainers API Call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Enables fine grained authorization for the v1 API call GET_CONTAINERS.
Diffs
-----
src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
** Needs more testing **
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: WIP: Enabled fine grained authorization for
the getContainers API Call.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158566
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54535, 54538]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 8, 2016, 5:33 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 5:33 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call GET_CONTAINERS.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
> src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> ** Needs more testing **
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: WIP: Enabled fine grained authorization for
the getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Dec. 11, 2016, 1:24 p.m., Adam B wrote:
> > src/slave/http.cpp, line 1833
> > <https://reviews.apache.org/r/54538/diff/2/?file=1580456#file1580456line1833>
> >
> > double-underscore? Do we just skip over `_containers()`? I suppose that's part of `/containers`?
pretty much so.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158795
-----------------------------------------------------------
On Dec. 9, 2016, 4:33 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:33 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call GET_CONTAINERS.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
> src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> ** Needs more testing **
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: WIP: Enabled fine grained authorization for
the getContainers API Call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158795
-----------------------------------------------------------
src/slave/http.cpp (line 1833)
<https://reviews.apache.org/r/54538/#comment229604>
double-underscore? Do we just skip over `_containers()`? I suppose that's part of `/containers`?
src/slave/http.cpp (lines 1901 - 1903)
<https://reviews.apache.org/r/54538/#comment229605>
No longer necessary
- Adam B
On Dec. 9, 2016, 7:33 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 7:33 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call GET_CONTAINERS.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
> src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> ** Needs more testing **
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158864
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54535, 54538]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2016, 10:46 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 10:46 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
> src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review159091
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Dec. 13, 2016, 6:47 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 6:47 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
> src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 3:47 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
Diffs
-----
src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 3:44 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description (updated)
-------
Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
Diffs
-----
src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 3:04 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description (updated)
-------
Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
Diffs (updated)
-----
src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158976
-----------------------------------------------------------
Looks good, but I'm tired. I'll merge all these in tomorrow.
src/slave/http.cpp (line 1869)
<https://reviews.apache.org/r/54538/#comment229880>
Each parameter on a separate line, please
src/slave/http.cpp (line 1929)
<https://reviews.apache.org/r/54538/#comment229884>
Already called `info` a few lines above. Can you reuse that?
- Adam B
On Dec. 12, 2016, 2:46 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 2:46 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
> src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 11:46 a.m.)
Review request for mesos and Adam B.
Changes
-------
Added fine grained authz to the containers endpoint.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
Diffs (updated)
-----
src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing (updated)
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: Enabled fine grained authorization for the
getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 10:45 a.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Enabled fine grained authorization for the getContainers API Call.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description (updated)
-------
Enables fine grained authorization for the v1 API call `GET_CONTAINERS`.
Diffs (updated)
-----
src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
** Needs more testing **
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: WIP: Enabled fine grained authorization for
the getContainers API Call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 4:33 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Enables fine grained authorization for the v1 API call GET_CONTAINERS.
Diffs (updated)
-----
src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
Diff: https://reviews.apache.org/r/54538/diff/
Testing
-------
** Needs more testing **
make check
Thanks,
Alexander Rojas
Re: Review Request 54538: WIP: Enabled fine grained authorization for
the getContainers API Call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158661
-----------------------------------------------------------
src/slave/http.cpp (line 1826)
<https://reviews.apache.org/r/54538/#comment229458>
VIEW_CONTAINER
src/slave/http.cpp (line 1831)
<https://reviews.apache.org/r/54538/#comment229459>
No `[=]`, please?
src/slave/slave.hpp (lines 552 - 553)
<https://reviews.apache.org/r/54538/#comment229460>
Shouldn't we add this fine-grained authz to the /containers endpoint as well (currently protected by coarse-grained GET_ENDPOINT authz)?
- Adam B
On Dec. 8, 2016, 9:33 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54538/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 9:33 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables fine grained authorization for the v1 API call GET_CONTAINERS.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
> src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
>
> Diff: https://reviews.apache.org/r/54538/diff/
>
>
> Testing
> -------
>
> ** Needs more testing **
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>