[GitHub] [dolphinscheduler] qianli2022 commented on a change in pull request #9303: [Feature][Task] K8s namespace auth manager

[GitBox <gi...@apache.org>]

qianli2022 commented on a change in pull request #9303:
URL: https://github.com/apache/dolphinscheduler/pull/9303#discussion_r840253789



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java
##########
@@ -154,13 +155,15 @@ public Result queryListPaging(User loginUser, String searchVal, Integer pageNo,
         k8sNamespaceObj.setCreateTime(now);
         k8sNamespaceObj.setUpdateTime(now);
 
-        try {
-            String yamlStr = genDefaultResourceYaml(k8sNamespaceObj);
-            k8sClientService.upsertNamespaceAndResourceToK8s(k8sNamespaceObj, yamlStr);
-        } catch (Exception e) {
-            logger.error("namespace create to k8s error", e);
-            putMsg(result, Status.K8S_CLIENT_OPS_ERROR, e.getMessage());
-            return result;
+        if (!"ds_null_k8s".equals(k8sNamespaceObj.getK8s())) {

Review comment:
       okey,it is used for local test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org