You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/20 10:44:45 UTC

[GitHub] [doris] xinyiZzz commented on pull request #11040: fix_arena_push_size

xinyiZzz commented on PR #11040:
URL: https://github.com/apache/doris/pull/11040#issuecomment-1190119739

   @muyizi 
   ChunkAllocator中的chunk大小必须是2^n ，`ChunkAllocator::allocate`不能申请1025，见接口注释，申请1025应该用`ChunkAllocator::allocate_align`
   
   应该在`ChunkAllocator::allocate`中加一个 DCKECK或return error检测size是否为2^n，
   然后把`ChunkAllocator::allocate`变成private，对MemPool设为friend class，对外只暴露`ChunkAllocator::allocate_align`。实际上`ChunkAllocator::allocate`现在只有MemPool使用，MemPool每次申请都是2^n


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org