You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/26 01:57:27 UTC

[GitHub] [skywalking] novayoung opened a new issue #5383: the optimization of "trace sql parameters"

novayoung opened a new issue #5383:
URL: https://github.com/apache/skywalking/issues/5383


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [* ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   When "trace_ sql_parameters" is true, the agent will record the parameters, but if the parameters are too large, the performance will be affected and the memory will be occupied. 
   I think it is better to get the truncated parameters string before build the full string of all the parameters.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] novayoung commented on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
novayoung commented on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680424079


   i know that, but truncation depends the full string. 
   ```
           String parameterString = getParameterString();  // Here is the string of parameters, maybe too large. 
           return truncate(parameterString);
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] novayoung removed a comment on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
novayoung removed a comment on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680424079


   i know that, but truncation depends the full string. 
   ```
           String parameterString = getParameterString();  // Here is the string of parameters, maybe too large. 
           return truncate(parameterString);
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] novayoung commented on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
novayoung commented on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680437359


   > We have `SQL_PARAMETERS_MAX_LENGTH` from day one, please recheck the doc.
   
   i know that, but truncation depends the full string. 
   ```
           String parameterString = getParameterString();  // Here is the string of parameters, maybe too large. 
           return truncate(parameterString);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680417233


   We have `SQL_PARAMETERS_MAX_LENGTH` from day one, please recheck the log.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5383:
URL: https://github.com/apache/skywalking/issues/5383


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng edited a comment on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680417233


   We have `SQL_PARAMETERS_MAX_LENGTH` from day one, please recheck the doc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] novayoung commented on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
novayoung commented on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680443908


   > OK, if you want to cut the string as soon as it reached the length limitation, you could optimize that.
   
   Ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5383: the optimization of "trace sql parameters"

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5383:
URL: https://github.com/apache/skywalking/issues/5383#issuecomment-680440979


   OK, if you want to cut the string as soon as it reached the length limitation, you could optimize that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org