You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/20 18:47:16 UTC
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5335: xcp-ng: allow passing vm boot options
shwstppr commented on a change in pull request #5335:
URL: https://github.com/apache/cloudstack/pull/5335#discussion_r693151719
##########
File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1955,10 +1955,10 @@ protected void setVmBootDetails(final VM vm, final Connection conn, String bootT
boolean isSecure = bootType.equals(ApiConstants.BootType.UEFI.toString()) &&
ApiConstants.BootMode.SECURE.toString().equals(bootMode);
final Map<String, String> bootParams = vm.getHVMBootParams(conn);
- bootParams.replace("firmware", bootType);
+ bootParams.replace("firmware", bootType.toLowerCase());
vm.setHVMBootParams(conn, bootParams);
final Map<String, String> platform = vm.getPlatform(conn);
- platform.put("secureboot", isSecure ? "true" : "false");
+ platform.put("secureboot", Boolean.toString(isSecure));
Review comment:
Not sure how that helps or improves performance. Unless the point is to make code look good in a certain way.
And that has been the whole point of reviews lately IMO.
Anyway, changed it before it becomes an argument and RM has to change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org