You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/16 18:55:24 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #17343: CMake: Attempt using ccache by default if available

leezu opened a new pull request #17343: CMake: Attempt using ccache by default if available
URL: https://github.com/apache/incubator-mxnet/pull/17343
 
 
   ## Description ##
   Attempt using ccache by default if available. Simplifies user's build commands from
   
   ```
   cmake -GNinja \
       -DUSE_CUDA=OFF \
       -DUSE_MKL_IF_AVAILABLE=OFF \
       -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
       -DCMAKE_C_COMPILER_LAUNCHER=ccache \
       -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
       -DCMAKE_BUILD_TYPE=Release \
   ..
   ninja
   ```
   
   to
   
   ```
   cmake -GNinja \
       -DUSE_CUDA=OFF \
       -DUSE_MKL_IF_AVAILABLE=OFF \
       -DCMAKE_BUILD_TYPE=Release \
   ..
   ninja
   ```
   
   - Introduces USE_CCACHE=ON variable
   - Simplifies setup instructions for users
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] CMake: Attempt using ccache by default if available
   
   ## Comments ##
   CC @larroy 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17343: CMake: Attempt using ccache by default if available

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17343: CMake: Attempt using ccache by default if available
URL: https://github.com/apache/incubator-mxnet/pull/17343#issuecomment-575513974
 
 
   Thanks! Usability +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17343: CMake: Attempt using ccache by default if available

Posted by GitBox <gi...@apache.org>.
ChaiBapchya removed a comment on issue #17343: CMake: Attempt using ccache by default if available
URL: https://github.com/apache/incubator-mxnet/pull/17343#issuecomment-575513974
 
 
   Thanks! Usability +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu merged pull request #17343: CMake: Attempt using ccache by default if available

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17343: CMake: Attempt using ccache by default if available
URL: https://github.com/apache/incubator-mxnet/pull/17343
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services