You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/06/24 19:01:28 UTC
[GitHub] [jackrabbit-oak] pat-lego opened a new pull request, #605: Adding path name to the logs
pat-lego opened a new pull request, #605:
URL: https://github.com/apache/jackrabbit-oak/pull/605
Adding the path name to the IllegalArgumentException in order to get a context to where the issue resides in.
This is reference to this JIRA: https://issues.apache.org/jira/browse/OAK-9815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] joerghoh merged pull request #605: Adding path name to the logs
Posted by GitBox <gi...@apache.org>.
joerghoh merged PR #605:
URL: https://github.com/apache/jackrabbit-oak/pull/605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] joerghoh commented on pull request #605: Adding path name to the logs
Posted by GitBox <gi...@apache.org>.
joerghoh commented on PR #605:
URL: https://github.com/apache/jackrabbit-oak/pull/605#issuecomment-1177229180
As suggested on oak-dev I created issues for the failing tests:
* https://issues.apache.org/jira/browse/OAK-9825 (oak-store-document)
* https://issues.apache.org/jira/browse/OAK-9826 (oak-blob-plugins)
* https://issues.apache.org/jira/browse/OAK-9827 (oak-segment-azure)
But will merge it anway, as they are unrelated to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #605: Adding path name to the logs
Posted by GitBox <gi...@apache.org>.
joerghoh commented on code in PR #605:
URL: https://github.com/apache/jackrabbit-oak/pull/605#discussion_r913501053
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableTree.java:
##########
@@ -348,7 +348,7 @@ private void beforeRead() throws IllegalStateException {
private void beforeWrite() throws IllegalStateException {
beforeRead();
if (!super.exists()) {
- throw new IllegalStateException("This tree does not exist");
+ throw new IllegalStateException("This tree does not exist for " + super.getPath());
Review Comment:
```suggestion
throw new IllegalStateException("The tree for " + super.getPath() + " does not exist);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org