[jira] [Commented] (HTRACE-44) Search page skeleton

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263270#comment-14263270 ] 

Colin Patrick McCabe commented on HTRACE-44:
--------------------------------------------

Cool!

{code}
App.Span = Backbone.Model.extend({
22	  "defaults": {
23	    "spanId": null,
24	    "parentSpanId": null,
25	    "processId": null,
26	    "description": null,
27	    "startTime": 0,
28	    "endTime": 0,
29	    "accumulatedTime": 0
30	  }
31	});
{code}

These don't match up with the JSON fields from {{Span.java}} / {{span.go}}.  For example, "begin" is "b", not "startTime".  Can you make these match up?  Also, I think {{accumulatedTime}} will have to be calculated (perhaps by a function on the javascript object?) since it is not an explicit field in our JSON.  It's just {{e - b}} (end minus beginning).

{{htrace-core/src/web/lib/css/main.css}}: does this file need an apache header?

+1 once those are addressed

> Search page skeleton
> --------------------
>
>                 Key: HTRACE-44
>                 URL: https://issues.apache.org/jira/browse/HTRACE-44
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>         Attachments: HTRACE-44.0.patch, Search page skeleton - 0.png
>
>
> Create a skeleton for the search page. This should include Backbone models and views. This ticket should cover rudimentary support for displaying a list of spans based on some filters/search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)