[GitHub] [commons-io] kinow commented on pull request #462: IO-805 - FilenameUtils.isIPv4Address does not handle illegal integers

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on PR #462:
URL: https://github.com/apache/commons-io/pull/462#issuecomment-1606693788

   > Hi @kinow, isIpv4Address method is a private method. there is a way can I test it?
   
   There must be. It must be accessible via a public method somewhere. I think `getPrefixLength` calls` `isIpv6` that calls the `isIpv4`. If that's correct, then a test would have to be written for `getPrefixLength` that triggers the code modified here, otherwise there's no way to make sure that a) it works as expected nor b) that it won't be changed by another dev later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org