You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "sandeepnkulkarni (via GitHub)" <gi...@apache.org> on 2023/03/19 14:11:48 UTC

[GitHub] [httpcomponents-core] sandeepnkulkarni commented on pull request #398: Return emptySet or emptyList instead of null to honor contract for re…

sandeepnkulkarni commented on PR #398:
URL: https://github.com/apache/httpcomponents-core/pull/398#issuecomment-1475272612

   Majority of the changes proposed here are around method [getTrailerNames()](https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/http/EntityDetails.java#L66) in EntityDetails interface.
   
   There are many places where we are already returning immutable collection for implementation of this method. I believe that is what is correct. But few places were returning null. This PR fixes those issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org