You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/11/27 15:17:01 UTC

[GitHub] carbondata pull request #2958: [CARBONDATA-3136] JVM crash with preaggregate...

GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2958

    [CARBONDATA-3136] JVM crash with preaggregate datamap when average of decimal column is taken with orderby.  

    problem:  JVM crash with preaggregate datamap when average of decimal column is taken with orderby.  
    
    cause: When preparing plan with preaggregate datamap, decimal is cast to double in average expression. This was leading to JVM crash in spark as we were filling with wrong precision (callstack mentioned in JIRA) 
    
    solution: division result of average, should be casted to decimal instead of double for decimal datatype.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed? NA
     
     - [ ] Any backward compatibility impacted? NA
     
     - [ ] Document update required? NA
    
     - [ ] Testing done.   
           yes, added UT       
    
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata issue_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2958
    
----
commit 8d95838e5d5991d7c355944d40a54972ea1c1424
Author: ajantha-bhat <aj...@...>
Date:   2018-11-27T14:07:49Z

    jvm crash when query pre-aggreagte table with avg(decimal_column) and order by

----


---

[GitHub] carbondata issue #2958: [CARBONDATA-3136] Fix JVM crash with preaggregate da...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2958
  
    LGTM


---

[GitHub] carbondata issue #2958: [CARBONDATA-3136] JVM crash with preaggregate datama...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2958
  
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1770/



---

[GitHub] carbondata issue #2958: [CARBONDATA-3136] JVM crash with preaggregate datama...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2958
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1559/



---

[GitHub] carbondata pull request #2958: [CARBONDATA-3136] Fix JVM crash with preaggre...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2958


---

[GitHub] carbondata issue #2958: [CARBONDATA-3136] JVM crash with preaggregate datama...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2958
  
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9817/



---