You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/08/21 12:58:00 UTC
[jira] [Commented] (HBASE-24914) Remove duplicate code appearing
continuously in method ReplicationPeerManager.updatePeerConfig
[ https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181866#comment-17181866 ]
Hudson commented on HBASE-24914:
--------------------------------
Results for branch master
[build #13 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/13/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/13/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/13/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/13/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/13//artifact/output-integration/hadoop-2.log]. (note that this means we didn't run on Hadoop 3)
> Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-24914
> URL: https://issues.apache.org/jira/browse/HBASE-24914
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Affects Versions: 3.0.0-alpha-1
> Reporter: Sun Xin
> Assignee: Sun Xin
> Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> In [ReplicationPeerManager.updatePeerConfig|https://github.com/apache/hbase/blob/1164531d5ab519ab58af82ba3849f8fcded3453f/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L272], I found duplicate code appearing twice continuously, so remove once.
> {code:java}
> newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration());
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)