You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/28 14:40:23 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1980: [KYUUBI #1969] Fix race on some service during stop phase

yaooqinn commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815948030



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       then what actually varies the order you present here,are we good to go?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org