You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/19 22:01:59 UTC
[kudu-CR] [test] fix negotiation-test for krb5 version 1.19.2
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20599
Change subject: [test] fix negotiation-test for krb5 version 1.19.2
......................................................................
[test] fix negotiation-test for krb5 version 1.19.2
TestNegotiation.TestPreflight was failing on Ubuntu 22.04.3 LTS
because of the error message mismatch:
src/kudu/rpc/negotiation-test.cc:1533: Failure
Value of: s.ToString()
Expected: contains regular expression "error accessing keytab: Permission denied
"
Actual: "Runtime error: GSSAPI Error: No credentials were supplied, or the credentials were unavailable or inaccessible (Permission denied)"
This patch addresses the issue, making the reference error message
pattern more generic.
Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
---
M src/kudu/rpc/negotiation-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/20599/1
--
To view, visit http://gerrit.cloudera.org:8080/20599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Gerrit-Change-Number: 20599
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [test] fix negotiation-test for krb5 version 1.19.2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20599 )
Change subject: [test] fix negotiation-test for krb5 version 1.19.2
......................................................................
[test] fix negotiation-test for krb5 version 1.19.2
TestNegotiation.TestPreflight was failing on Ubuntu 22.04.3 LTS
because of the error message mismatch:
src/kudu/rpc/negotiation-test.cc:1533: Failure
Value of: s.ToString()
Expected: contains regular expression "error accessing keytab: Permission denied
"
Actual: "Runtime error: GSSAPI Error: No credentials were supplied, or the credentials were unavailable or inaccessible (Permission denied)"
This patch addresses the issue, making the reference error message
pattern more generic.
Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Reviewed-on: http://gerrit.cloudera.org:8080/20599
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/rpc/negotiation-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Gerrit-Change-Number: 20599
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [test] fix negotiation-test for krb5 version 1.19.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20599 )
Change subject: [test] fix negotiation-test for krb5 version 1.19.2
......................................................................
Patch Set 1: Verified+1
unrelated test failure in TlsSocketTest.TestRecvFailure (DEBUG)
--
To view, visit http://gerrit.cloudera.org:8080/20599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Gerrit-Change-Number: 20599
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 20 Oct 2023 00:03:02 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix negotiation-test for krb5 version 1.19.2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20599 )
Change subject: [test] fix negotiation-test for krb5 version 1.19.2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Gerrit-Change-Number: 20599
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 20 Oct 2023 00:04:22 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix negotiation-test for krb5 version 1.19.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] fix negotiation-test for krb5 version 1.19.2
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If4a3772fa50fc799756da121644c9dbb4d9bc977
Gerrit-Change-Number: 20599
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>