You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/22 15:26:03 UTC
[GitHub] [iceberg] bijanhoule opened a new pull request, #5112: Spark 3.2: RewriteDataFiles - Escape special characters in table identifiers
bijanhoule opened a new pull request, #5112:
URL: https://github.com/apache/iceberg/pull/5112
Allows e.g. `db.special-chars`.`table.special-chars` when calling the RewriteDataFiles action or procedure, e.g.:
```sql
CALL system.rewrite_data_files(table => '`db.with-special`.`table.with-special`')
```
Currently this causes an exception as the full identifier (`<catalog>.<database>.<table>`) is stringified without any quoting.
```
IllegalArgumentException: Cannot parse path or identifier: dev.db.with-special.table.with-special
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] bijanhoule commented on a diff in pull request #5112: Spark 3.2: RewriteDataFiles - Escape special characters in table identifiers
Posted by GitBox <gi...@apache.org>.
bijanhoule commented on code in PR #5112:
URL: https://github.com/apache/iceberg/pull/5112#discussion_r905215064
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -61,6 +61,12 @@ default RewriteDataFiles rewriteDataFiles(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does not implement rewriteDataFiles");
}
+ default RewriteDataFiles rewriteDataFiles(Table table, String fullIdentifier) {
Review Comment:
good idea -- added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on a diff in pull request #5112: Spark 3.2: RewriteDataFiles - Escape special characters in table identifiers
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on code in PR #5112:
URL: https://github.com/apache/iceberg/pull/5112#discussion_r905207544
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -61,6 +61,12 @@ default RewriteDataFiles rewriteDataFiles(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does not implement rewriteDataFiles");
}
+ default RewriteDataFiles rewriteDataFiles(Table table, String fullIdentifier) {
Review Comment:
Should we mark the other interface as `@Deprecated`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #5112: Spark 3.2: RewriteDataFiles - Escape special characters in table identifiers
Posted by GitBox <gi...@apache.org>.
danielcweeks merged PR #5112:
URL: https://github.com/apache/iceberg/pull/5112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org