You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/05/27 16:59:34 UTC

svn commit: r1860147 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java

Author: tilman
Date: Mon May 27 16:59:34 2019
New Revision: 1860147

URL: http://svn.apache.org/viewvc?rev=1860147&view=rev
Log:
PDFBOX-4553: narrow condition to discard capHeight

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java?rev=1860147&r1=1860146&r2=1860147&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/text/LegacyPDFStreamEngine.java Mon May 27 16:59:34 2019
@@ -181,11 +181,11 @@ class LegacyPDFStreamEngine extends PDFS
             {
                 glyphHeight = capHeight;
             }
-            // PDFBOX-3464, PDFBOX-448:
+            // PDFBOX-3464, PDFBOX-4480, PDFBOX-4553:
             // sometimes even CapHeight has very high value, but Ascent and Descent are ok
             float ascent = fontDescriptor.getAscent();
             float descent = fontDescriptor.getDescent();
-            if (ascent > 0 && descent < 0 &&
+            if (capHeight > ascent && ascent > 0 && descent < 0 &&
                 ((ascent - descent) / 2 < glyphHeight || Float.compare(glyphHeight, 0) == 0))
             {
                 glyphHeight = (ascent - descent) / 2;