You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Norman Maurer <nm...@byteaction.de> on 2006/06/21 07:31:21 UTC
Re: [jira] Updated: (JAMES-515) Remove RepositoryManager
and cornerstone-store-impl
For me its no big deal on merge it to branch too.. IT only cleanup some
code and remove 2 unneeded classes an 1 unneded jar.
Im +1 to aplly it to branch. Why we should ship more code and jars then
we need ?
bye
Norman
Am Mittwoch, den 21.06.2006, 02:19 +0200 schrieb Bernd Fondermann:
> Norman Maurer wrote:
> > +1 for apply the patch to trunk and 2.3-branch!
>
> Mmmh... being +1 on the task for trunk, I question if such a change is
> really worth being applied to 2.3? it sounds like a cleanup, prio is
> 'minor', doesn't seem to be neccessary to have it in 2.3.
> Where do we draw the line between trunk/2.3 changes?
>
> Again, please go ahead for trunk.
>
> Bernd
>
> >
> >
> > bye
> > Norman
> >
> > Am Dienstag, den 20.06.2006, 09:13 +0000 schrieb Stefano Bagnara (JIRA):
> >
> >> [ http://issues.apache.org/jira/browse/JAMES-515?page=all ]
> >>
> >>Stefano Bagnara updated JAMES-515:
> >>----------------------------------
> >>
> >> Attachment: JAMES-515.diff
> >>
> >>patch should be applied, and cornerstone-store-impl-2.1.jar removed
> >>
> >>
> >>>Remove RepositoryManager and cornerstone-store-impl
> >>>---------------------------------------------------
> >>>
> >>> Key: JAMES-515
> >>> URL: http://issues.apache.org/jira/browse/JAMES-515
> >>> Project: James
> >>> Type: Task
> >>
> >>> Components: Build System
> >>> Versions: 2.3.0, 2.4.0
> >>> Reporter: Stefano Bagnara
> >>> Assignee: Stefano Bagnara
> >>> Priority: Minor
> >>> Fix For: 2.3.0, 2.4.0
> >>> Attachments: JAMES-515.diff
> >>>
> >>>RepositoryManager is not used anymore => Delete it.
> >>>cornerstone-store-impl should not be used => Delete it, remove from build process, check it works.
> >>>We could probably remove the whole Store api as we don't even use their implementation.
> >>>Maybe we could remove the whole "objectrepository" stuff, hardcoding object and stream repository creation/lookup directly in the AvalonMailRepository and UsersFileRepository.
> >>>This remove some modularity but this modularity is only in file storage and we want to deprecate cornerstone components, so I think this is a needed step.
> >>>Has anyone ever customized James altering the Object and Stream repository factory?
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
> http://217.195.2.164:8080/bytestor/servlet/bytestor/template/storedMail,SetStatusOneTime.vm?stored_mail_id=4868&password=kZixmQn6AcNeSfiAn6XKXJNLgHVeYDk4S5nzgf
> !EXCUBATOR:1,4498903f43378009619964!
Re: [jira] Updated: (JAMES-515) Remove RepositoryManager and cornerstone-store-impl
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Norman Maurer wrote:
> For me its no big deal on merge it to branch too.. IT only cleanup some
> code and remove 2 unneeded classes an 1 unneded jar.
>
> Im +1 to aplly it to branch. Why we should ship more code and jars then
> we need ?
A valid reason could be that a release branch should be changed as less
as possible because
+ less new bugs will be introduced - especially those hidden, nasty ones
+ every change could invalidate tests run before
+ optimizing the number of lines or jars shipped is not so important at
this stage
+ peer reviewers can much better track what's happening
I'm not vetoing anything, I am just trying to understand which patches
we want to apply to branch and which not.
Bernd
>
> bye
> Norman
>
>
> Am Mittwoch, den 21.06.2006, 02:19 +0200 schrieb Bernd Fondermann:
>
>>Norman Maurer wrote:
>>
>>>+1 for apply the patch to trunk and 2.3-branch!
>>
>>Mmmh... being +1 on the task for trunk, I question if such a change is
>>really worth being applied to 2.3? it sounds like a cleanup, prio is
>>'minor', doesn't seem to be neccessary to have it in 2.3.
>>Where do we draw the line between trunk/2.3 changes?
>>
>>Again, please go ahead for trunk.
>>
>> Bernd
>>
>>
>>>
>>>bye
>>>Norman
>>>
>>>Am Dienstag, den 20.06.2006, 09:13 +0000 schrieb Stefano Bagnara (JIRA):
>>>
>>>
>>>> [ http://issues.apache.org/jira/browse/JAMES-515?page=all ]
>>>>
>>>>Stefano Bagnara updated JAMES-515:
>>>>----------------------------------
>>>>
>>>> Attachment: JAMES-515.diff
>>>>
>>>>patch should be applied, and cornerstone-store-impl-2.1.jar removed
>>>>
>>>>
>>>>
>>>>>Remove RepositoryManager and cornerstone-store-impl
>>>>>---------------------------------------------------
>>>>>
>>>>> Key: JAMES-515
>>>>> URL: http://issues.apache.org/jira/browse/JAMES-515
>>>>> Project: James
>>>>> Type: Task
>>>>
>>>>> Components: Build System
>>>>> Versions: 2.3.0, 2.4.0
>>>>> Reporter: Stefano Bagnara
>>>>> Assignee: Stefano Bagnara
>>>>> Priority: Minor
>>>>> Fix For: 2.3.0, 2.4.0
>>>>>Attachments: JAMES-515.diff
>>>>>
>>>>>RepositoryManager is not used anymore => Delete it.
>>>>>cornerstone-store-impl should not be used => Delete it, remove from build process, check it works.
>>>>>We could probably remove the whole Store api as we don't even use their implementation.
>>>>>Maybe we could remove the whole "objectrepository" stuff, hardcoding object and stream repository creation/lookup directly in the AvalonMailRepository and UsersFileRepository.
>>>>>This remove some modularity but this modularity is only in file storage and we want to deprecate cornerstone components, so I think this is a needed step.
>>>>>Has anyone ever customized James altering the Object and Stream repository factory?
>>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>http://217.195.2.164:8080/bytestor/servlet/bytestor/template/storedMail,SetStatusOneTime.vm?stored_mail_id=4868&password=kZixmQn6AcNeSfiAn6XKXJNLgHVeYDk4S5nzgf
>>!EXCUBATOR:1,4498903f43378009619964
>
> !
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org